[MU3] Fix MSVC compiler warnings #7249
Conversation
| @@ -684,7 +684,7 @@ class MuseScore : public QMainWindow, public MuseScoreCore { | |||
| void loadFile(const QUrl&); | |||
| QTemporaryFile* getTemporaryScoreFileCopy(const QFileInfo& info, const QString& baseNameTemplate); | |||
| QNetworkAccessManager* networkManager(); | |||
| virtual Score* openScore(const QString& fn, bool switchTab = true, const bool appendToExistingTabs = true); | |||
| virtual Score* openScore(const QString& fn, bool switchTab = true, const bool appendToExistingTabs = true) override; | |||
There was a problem hiding this comment.
Review needed, it does fix a compiler warning but I'm not sure whether we really want to override Ms::MuseScoreCore::openScore() from libmscore/musescoreCore.h line 45 here?
There was a problem hiding this comment.
Does it matter? I think it is going to be overridden with or without override
There was a problem hiding this comment.
It was implicitly overridden, is now explcitly overridden, that apeases the compiler (i.e. no warning any more). Question is whether this really wanted.
I guess it is (and am relatively sure by now), as that other one is basically a dummy or stub.
There was a problem hiding this comment.
I'm just saying even if that wasn't what we want, it still would not be solved (returned to the behaviour of parent class) just by not adding override. Am I wrong?
There was a problem hiding this comment.
No, you're not wrong. And that's exactly why I started this discussion here ;-)
No description provided.