Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #290356: Allow copy-pasting of the LetRing, PalmMute and Vibrato elements. #7260

Conversation

dnovikov
Copy link

Resolves: https://musescore.org/en/node/290356

This code converts HairPin, LetRing, PalmMute and Vibrato to spanners, to utilize setTick() and setTrack2() methods. This prepares the ground to be used for any line element.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@MarcSabatella
Copy link
Contributor

That sounds like an ambitious goal, but surely there is a much simpler and a safer / more backwards-compatible fix for the short term? Shouldn't it just be to add the appropriate handler to a switch statement?

@dnovikov dnovikov force-pushed the 290356-cannot-copy-palmmute-vibrato-letring branch from 687d1ef to 6b52253 Compare January 17, 2021 19:12
@dnovikov
Copy link
Author

@MarcSabatella thank you for pointing out the right direction. I compiled the code with the switch statement only, and it worked fine.

@dnovikov dnovikov changed the title fix #290356: Allow copy-pasting of the LetRing, PalmMute and Vibrato elements, based on HairPin paste implementation. fix #290356: Allow copy-pasting of the LetRing, PalmMute and Vibrato elements. Jan 17, 2021
@MarcSabatella
Copy link
Contributor

Nice! I actually had no idea where the switch was :-), but I figured it had be something like this.

@vpereverzev vpereverzev merged commit 154112b into musescore:3.x Jan 18, 2021
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 12, 2021
vpereverzev pushed a commit that referenced this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants