fix #316096, fix #305093: custom gliss text reverts to default "gliss" #7315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://musescore.org/en/node/316096 Resolves: https://musescore.org/en/node/305093 Issue is that customized gliss text reverts back to the default "gliss". In all 3.x versions, this happened after saving, reloading, then making any style change. In 3.6, this happens immediately on the save/reload. Cause is that the property was never makred unstyled on read. Fix is to change the plain setting of "_text" with a call to readProperty() on Pid::GLISS_TEXT.
49 tasks
|
FWIW, two different reports of this bug came in over the weekend. So it wasn't part of the batch of Trello issues I added last week, but definitely worth including. |
53 tasks
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 11, 2021
vpereverzev
pushed a commit
that referenced
this pull request
Feb 11, 2021
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/316096
Resolves: https://musescore.org/en/node/305093
Issue is that customized gliss text reverts back to the default "gliss".
In all 3.x versions, this happened after saving, reloading,
then making any style change.
In 3.6, this happens immediately on the save/reload.
Cause is that the property was never makred unstyled on read.
Fix is to change the plain setting of "_text" with
a call to readProperty() on Pid::GLISS_TEXT.