Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #316125: Dock widgets are now focused on visibilty toggle #7333

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

sidharth-anand
Copy link
Contributor

@sidharth-anand sidharth-anand commented Jan 26, 2021

Resolves: https://musescore.org/en/node/316125

This patch modifies the reDisplayDockWidget function in musescore.cpp to make sure that when the visibility of docked widgets like the mixer/inspector is toggled, the widget is focused and appears on top in the dock

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@Jojo-Schmitz
Copy link
Contributor

What's your username on musescore.org?

@sidharth-anand
Copy link
Contributor Author

85sid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants