Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] Fix macOS dmg name, fix macOS dmg window height, update version number #7360

Merged
merged 3 commits into from Jan 29, 2021

Conversation

cbjeukendrup
Copy link
Contributor

  • Fixed macOS dmg name
    The name of the downloaded dmg was okay, but the name of the volume that is mounted when you open the dmg was wrong:
    Schermafbeelding 2021-01-28 om 21 56 21
    I fixed it in such way that it will match what was intended previously. If we ever want to change it, that can be done very easily now.

  • Fixed macOS dmg window height
    Make the full background image visible, by taking the height of the window title bar into account.

  • Update version number
    To 3.6.2. (I assumed that would be desired, or isn't it?)

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

Make the full background image visible, by taking the height of the window title bar into account.
@cbjeukendrup cbjeukendrup marked this pull request as ready for review January 28, 2021 22:31
@igorkorsukov igorkorsukov merged commit 6e77016 into musescore:3.x Jan 29, 2021
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jan 29, 2021

Would a change equivalent to 0ef97b5#diff-9e7722ca57674a1f6b12e1b419c1cd4918ab641dd58b60127de7427417ade066L3-R3 be needed here too?

(Sorry, a tad late...)

@cbjeukendrup cbjeukendrup mentioned this pull request Feb 4, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants