Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4] Bring back style options for multi-measure rests #7513

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

cbjeukendrup
Copy link
Contributor

They were introduced in PR #6211 by @IsaacWeiss, but got lost in PR #7462. Now, they are back again.

Schermafbeelding 2021-02-12 om 17 11 27

TODO: the same for the Measure Repeat options from PR #6365. Those got lost longer ago, and to me it is unclear when and why.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

They were introduced in PR musescore#6211 by Isaac Weiss, but got lost in PR musescore#7462. Now, they are back again.
@RomanPudashkin RomanPudashkin merged commit 98ac59b into musescore:master Feb 12, 2021
@cbjeukendrup cbjeukendrup deleted the editstyle-mmrest branch February 12, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants