[MU3] Fix typo in a the name of a style setting #7711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm slightly puzzled that 3.x needs these changes to vtests for them to pass, but for master it does not? |
njvdberg
reviewed
Mar 9, 2021
| @@ -434,7 +434,7 @@ static const StyleType styleTypes[] { | |||
| { Sid::mmRestNumberPos, "mmRestNumberPos", Spatium(-1.5) }, | |||
| { Sid::hideEmptyStaves, "hideEmptyStaves", QVariant(false) }, | |||
| { Sid::dontHideStavesInFirstSystem, | |||
| "dontHidStavesInFirstSystm", QVariant(true) }, | |||
| "dontHideStavesInFirstSystem", QVariant(true) }, | |||
There was a problem hiding this comment.
Does this name change cause compatibility issues with existing scores?
There was a problem hiding this comment.
No, that's what the 2nd chunk of this change is about.
It may (read: will) cause downrev issues though, like when a score created woith this PR merged is read in a version before that, but that is for lyricsDashMaxLegth vs. lyricsDashMaxLength too.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 11, 2023
This reverts commit 89e9471, PR musescore#7711. Causes issues when reading scores containing "dontHideStavesInFirstSystem" with earlier 3.x releases.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
This reverts commit 89e9471, PR musescore#7711. Causes issues when reading scores containing "dontHideStavesInFirstSystem" with earlier 3.x releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For master see #7712