Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] Fix #297613: (Linux) File save can't determine file type without extension #7739

Closed
wants to merge 1 commit into from

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Mar 17, 2021

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking ui/Application/useNativeDialogs.

Resolves: https://musescore.org/en/node/297613

As far as I can tell this is not yet needed/feasible for master

…nsion

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
@RobFog
Copy link

RobFog commented Mar 17, 2021

cc @mirabilos

@MarcSabatella
Copy link
Contributor

I have mixed feelings on this, but not strong ones either way. To me neither option is exactly perfect.

@mirabilos
Copy link
Contributor

Erk, this is… not good.

On the other hand, the nōn-native file open dialogue is so slow (because it must generate preview pictures for .mscx files) it’s choosing between a rock and a hard place. I have quite a strong opinion against the nōn-native open dialogue, and in the save dialogue you can easily work around this by manually adding the required file extension instead of letting the software add it automatically :/

I’d research into why it doesn’t do that instead.

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 18, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 24, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 24, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 10, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 26, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 26, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 11, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
@Jojo-Schmitz
Copy link
Contributor Author

@mirabilos any outcome of your further research?

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
@Jojo-Schmitz
Copy link
Contributor Author

See #9000

@Jojo-Schmitz Jojo-Schmitz deleted the native-dialog branch September 2, 2021 10:39
@mirabilos
Copy link
Contributor

I said I’d, not I’ll… I’ve got few detail knowledge of GUI things personally.

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
…nsion

Duplicate of musescore#7739

This basically reverts 3390aab, so for Mac and Windows nothing changes, but for Linux it now defaults to use the Qt file dialogs rather than the native ones. Can still get changed in the advanced properties, by ticking `ui/Application/useNativeDialogs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants