Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] Solve issue of fixed spacer between last staff and bottom of page. #7756

Merged

Conversation

njvdberg
Copy link
Contributor

@njvdberg njvdberg commented Mar 19, 2021

Solve issue of fixed spacer between last staff and bottom of page.
A negative value for a fixed spacer on the last staff will no longer push the last staff below the Music Bottom Margin.

Also the behavior is similar for both pre-3.6 staff spacing and vertical staves adjustment:

  1. When creating a fixed spacer on the last staff the gap is the distance between the bottom of the last staff and Page Bottom Margin.

  2. When the gap is increased the last staff is pushed up.

  3. When the gap is decreased the last staff is pushed down but it will never pushed below the Music Bottom Margin

  4. Because both pre-3.6 staff spacing and vertical staves adjustment are based on dividing remaining space between the last staff and Music Bottom Margin, when maximum distances between staves and/or systems are too small, it is not possible to honor the fixed spacer on the last staff with violating these maximum distances. In these situation, the maximum distances take precedence and the fixed gap between the last staff and Music Bottom Margin. is honored.
    In this, a fixed spacer on the last staff shows a slightly different behavior as fixed spacers on other staves.

This PR for master is similar to #7757 for 3.x.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@RobFog
Copy link

RobFog commented Mar 23, 2021

Rebase needed.

A negative value for a fixed spacer on the last staff will no longer push the last staff below the Music Bottom Margin.
@njvdberg njvdberg force-pushed the negative-fixed-spacer-on-last-staff-3x branch from 210c9e6 to 7cda938 Compare March 24, 2021 09:41
@njvdberg
Copy link
Contributor Author

Rebase needed.

Done.

@vpereverzev vpereverzev merged commit 42c75b5 into musescore:3.x Apr 2, 2021
@njvdberg njvdberg deleted the negative-fixed-spacer-on-last-staff-3x branch April 2, 2021 16:47
@Jojo-Schmitz
Copy link
Contributor

I wonder whether this would need to get ported to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants