Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4] Solve a crash when score contains a vbox which is not on top of a page. #7779

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

njvdberg
Copy link
Contributor

When a VBox found, a VerticalGapData object is created but if this VBox wasn't the first element on a page, the application crashed because the constructor was looking for a Spacer on a non-existing staff.

PR #7778 is similar for 3.x.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@igorkorsukov igorkorsukov merged commit 24fa2ed into musescore:master Mar 22, 2021
@njvdberg njvdberg deleted the spacer-crash-master branch May 15, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants