Issue 24492 fixed - crash when add Volta in endBarLine

[cardinot]

http://musescore.org/en/node/24492

MuseScore crash when volta_element is add in the end bar line.

[cardinot]

Hello @wschweer,
that's true and I already pushed a new revision, could you have a look?

[cardinot]

Hello, what about this PR? =D

[cardinot]

Branch updated!

[Jojo-Schmitz]

Don't pull/merge from upstream, but rebase instead. Needs a push --force afterwards

[cardinot]

Thanks @Jojo-Schmitz, done!

[cardinot]

Is there any another problem with this fix yet? Oo

[cardinot]

Hello, I'll do it... but it would be nice if this PR could really be
merged...
This PR is opened for more than 3 months and I have been done dozens of
rebasings

2014-06-26 12:49 GMT+01:00 Joachim Schmitz notifications@github.com:

Rebase needed...

—
Reply to this email directly or view it on GitHub
#778 (comment).

[cardinot]

Rebased again...

[lasconic]

Fixed a bit differently ade25ad

[cardinot]

Sorry, but it is not fixed!
Try put the volta in the penultimate measure... it keeps crashing...

I pushed already a fix at this branch...

[lasconic]

Thank you for testing. I fixed the other place too. The fix is that branch is suboptimal except if you have a good reason to compare the rect of the measures (so 4 float comparisons) instead of the pointers to the measure.

[cardinot]

But I had changed it to use "lastMeasureMM" as well...
Anyway, ... thanks for close it.
It seems that community contributions are not helpful for this FOSS project, I apologize for have opened a PR here...

[lasconic]

I'm sorry if you feel it this way. The files are still comparing boundingRect https://github.com/musescore/MuseScore/pull/778/files Community contributions are very welcome and I hope you'll consider to contribute again.

[cardinot]

It is because the PR was closed by you, so it is frozen in an old version...

That is the reason why I said: "I pushed already a fix at this branch..."
As you can see here:
cardinot@85afe97

[lasconic]

Sorry I missed that.