Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU4] Change instrument id from musicXMLid to an unique instrument id #7995

Closed
wants to merge 2 commits into from
Closed

[MU4] Change instrument id from musicXMLid to an unique instrument id #7995

wants to merge 2 commits into from

Conversation

njvdberg
Copy link
Contributor

Resolves: https://musescore.org/en/node/320404

Change instrument id from musicXMLid to an unique instrument id as defined by the id attribute of the instrument tag in instruments.xml.

Main reason for this change are musicXMLid isn't unique for instruments. Also not all instruments have a musicXMLid defined.

A small check of the existing instruments.xml:

  1. 584 instruments defined.
  2. 561 instruments don't have an musicXMLid.
  3. There are only 335 unique musicXMLid's defined.
  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@njvdberg njvdberg changed the title Change instrument id from musicXMLid to an unique instrument id [MU4] Change instrument id from musicXMLid to an unique instrument id Apr 23, 2021
@njvdberg njvdberg force-pushed the instrumentid-master branch 3 times, most recently from d0dd867 to 02beed5 Compare May 5, 2021 14:44
@njvdberg
Correct a typo in method name
dc771eb
@njvdberg
Change instrument id from musicXMLid to an unique instrument id as de…
977a508 
…fined by the "id" attribute of the "instrument" tag in instruments.xml.

Reasons for this change are:
 - musicXMLid isn't unique for instruments.
 - not all instruments have a musicXMLid defined.
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request May 10, 2021
Closed
@njvdberg njvdberg mentioned this pull request May 13, 2021
Merged
8 tasks
@njvdberg
Copy link
Contributor Author

This PR is included in PR #8099 .

@njvdberg njvdberg closed this May 13, 2021
@njvdberg njvdberg deleted the instrumentid-master branch May 13, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@njvdberg