Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #270988: [MusicXML] first-fret tag not supported for fretboard di… #8059

Closed
wants to merge 1 commit into from
Closed

Fix #270988: [MusicXML] first-fret tag not supported for fretboard di… #8059

wants to merge 1 commit into from

Conversation

lvinken
Copy link
Contributor

@lvinken lvinken commented May 7, 2021

…agrams

Resolves: https://musescore.org/en/node/270988

Support first-fret tag on both import and export.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@lvinken
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
b727157 
…agrams

Support first-fret tag on both import and export.
@lvinken
Copy link
Contributor Author

lvinken commented May 7, 2021

Note that I am aware that merges into 3.x are closed. This is to indicate the fix is available and has been tested OK. I am currently unable to provide a tested fix for master myself.

This was referenced May 7, 2021
Closed
Merged
@Jojo-Schmitz
Copy link
Contributor

See #8060 for a port to master

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 11, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
c07500c 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request May 19, 2021
Merged
8 tasks
@vpereverzev
Copy link
Member

Already merged into master, merges for 3.x are closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
d1b69d0 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
35b2b38 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
d2de6ff 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
0543bd3 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
44b9a58 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
a83703a 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
26c940c 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
0a51279 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
44f8a7f 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
3c1113a 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
0a74bf9 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
ae7f930 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
19aafc3 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
c72ad07 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
b8e2480 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
9343abb 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
b08cd6f 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@lvinken @Jojo-Schmitz
Fix #270988: [MusicXML] first-fret tag not supported for fretboard di…
9e39fad 
…agrams

Support first-fret tag on both import and export.

Duplicate of musescore#8059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lvinken @Jojo-Schmitz @vpereverzev