Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-30: Change non-end melismas to hyphens #8133

Merged
merged 1 commit into from May 21, 2021
Merged

[MU3 Backend] ENG-30: Change non-end melismas to hyphens #8133

merged 1 commit into from May 21, 2021

Conversation

iveshenry18
Copy link
Contributor

@iveshenry18 iveshenry18 commented May 21, 2021 •
edited

Resolves: ENG-30

Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in an underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@iveshenry18
ENG-30: Change non-end melismas to hyphens
c70d45d 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.
@iveshenry18 iveshenry18 changed the title ENG-30: Change non-end melismas to hyphens [MU3 Backend] ENG-30: Change non-end melismas to hyphens May 21, 2021
@vpereverzev vpereverzev merged commit e298be2 into musescore:3.6.2_backend May 21, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 21, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
c055066 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
a109a0c 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jun 29, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
1820a9f 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
e3c00c7 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
f174ef0 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
ba702e2 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
b6a53d1 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
f194af4 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
38bd60b 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
cd50b2a 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
5b46167 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
674970b 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
95188c4 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
d473788 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
e77c615 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
dee08f0 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
dada4d4 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
97f4107 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
@asattely asattely mentioned this pull request Oct 19, 2021
Closed
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@iveshenry18 @Jojo-Schmitz
ENG-30: Change non-end melismas to hyphens
3883acc 
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in a underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.

Port of musescore#8133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oktophonie oktophonie oktophonie approved these changes

@vpereverzev vpereverzev vpereverzev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iveshenry18 @oktophonie @vpereverzev