Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU4] Notenames plugins: For hidden notes skip notenames #8142

Merged
merged 2 commits into from Jun 13, 2021
Merged

[MU4] Notenames plugins: For hidden notes skip notenames #8142

merged 2 commits into from Jun 13, 2021

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented May 23, 2021 •
edited

This PR fixes:

  • If a note(head) is invisble, the notenames plugins still put a visible name to it.
  • If there's a list selection, only the 1st note of that gets named.

@Jojo-Schmitz Jojo-Schmitz changed the title [MU4] Notenames plugins: For hidden notes hide notenames too [MU4] Notenames plugins: For hidden notes skip notenames May 23, 2021
@Jojo-Schmitz Jojo-Schmitz force-pushed the notenames branch 2 times, most recently from 3530a10 to 25d56ff Compare May 23, 2021 11:43
@Jojo-Schmitz Jojo-Schmitz force-pushed the notenames branch 2 times, most recently from 0e2a995 to a166655 Compare May 24, 2021 09:12
@Jojo-Schmitz
Notenames plugins: For invisible notes skip notenames
842ca3d
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
379c6b7 
but in case of a list selection work on all that are (except invisble ones), not just the first
@RomanPudashkin RomanPudashkin merged commit 53aa417 into musescore:master Jun 13, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
5d3e8ff 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
ac0f96e 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
072bf1f 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
3bab1b7 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jul 23, 2021
Closed
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
b899f93 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
5dd3fb8 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
4e8b9b0 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
cf245c0 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
4af8f05 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
3ebd639 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
88b5a55 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
36dcfc5 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
9094ddd 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
bafe08f 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
f32283a 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
c62412e 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
3a79be2 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
1aab943 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
e9796d5 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
8d42e8f 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
402fabc 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
93b54fe 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
879bd76 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
e1cfb79 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
0a2fb72 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
f975290 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
5c7c253 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
506e244 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
a642536 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
add0027 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 2, 2021
Closed
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
cdd353e 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
3f4dd00 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
c22652f 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
19745ce 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@Jojo-Schmitz
Notenames plugins: For hidden notes skip notenames
7559ea3 
Backport of musescore#8142, part 1
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@Jojo-Schmitz
Notenames plugins: skip notes that are not selected
367c4f7 
but in case of a list selection work on all that are (except invisble ones), not just the first

Backport of musescore#8142, part 2
@Jojo-Schmitz Jojo-Schmitz deleted the notenames branch May 11, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizofaus wizofaus wizofaus approved these changes

@RomanPudashkin RomanPudashkin RomanPudashkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jojo-Schmitz @wizofaus @RomanPudashkin