Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIDI import: optimization for speed #815

Merged
merged 54 commits into from
Apr 2, 2014
Merged

MIDI import: optimization for speed #815

merged 54 commits into from
Apr 2, 2014

Commits on Apr 2, 2014

  1. Bool flag instead of int counter in filterTuplets function

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    4f127ad View commit details
    Browse the repository at this point in the history

  2. Optimization: move tuplet interval search outside the loop

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    b8ec722 View commit details
    Browse the repository at this point in the history

  3. Further optimization: precalculate all tuplet intervals

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    a6539fa View commit details
    Browse the repository at this point in the history

  4. Use regular raster from TupletInfo, not from function parameter

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    6da90b0 View commit details
    Browse the repository at this point in the history

  5. Fix addition of unused tuplet to tuplet intervals

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    13fb133 View commit details
    Browse the repository at this point in the history

  6. Optimize voice count calculation for tuplet error

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    041b616 View commit details
    Browse the repository at this point in the history

  7. Reorder conditions for small optimization

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    4160f75 View commit details
    Browse the repository at this point in the history

  8. Refactoring of isMoreTupletVoicesAllowed function

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    0c3f1a2 View commit details
    Browse the repository at this point in the history

  9. Less line breaks

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    1b74028 View commit details
    Browse the repository at this point in the history

  10. Reduce fraction only if numerator or denominator > some limit

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    83b3af4 View commit details
    Browse the repository at this point in the history

  11. Check fraction overflow only in Debug mode

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    c92659e View commit details
    Browse the repository at this point in the history

  12. Optimize tuplet validation

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    1b32fa0 View commit details
    Browse the repository at this point in the history

  13. Remove empty lines

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    e7443fa View commit details
    Browse the repository at this point in the history

  14. Optimize assert function (tuplet validation)

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    2447965 View commit details
    Browse the repository at this point in the history

  15. Fix of possible bug: now reset all usedVoices values

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    18841b1 View commit details
    Browse the repository at this point in the history

  16. Fix multiple times excluded chords error estimation

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    2ef5e8c View commit details
    Browse the repository at this point in the history

  17. New findCommonIndexes function to find 3 and more tuplet groups

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    4172afb View commit details
    Browse the repository at this point in the history

  18. Set permutation limit exactly to 8!

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    4e2c430 View commit details
    Browse the repository at this point in the history

  19. Print debug message if tuplet permutation limit was exceeded

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    d1d7f4f View commit details
    Browse the repository at this point in the history

  20. Fix chords^2 execution time of removeOverlappingNotes function

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    6b8b0ff View commit details
    Browse the repository at this point in the history

  21. Correct function description

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    9002a29 View commit details
    Browse the repository at this point in the history

  22. Refactor condition

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    56f1392 View commit details
    Browse the repository at this point in the history

  23. Small optimization of tuplet error calculation

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    1087de9 View commit details
    Browse the repository at this point in the history

  24. Refactor clef changes code

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    6020225 View commit details
    Browse the repository at this point in the history

  25. Remove check for chord emptiness in tuplets

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    5586a11 View commit details
    Browse the repository at this point in the history

  26. Remove penalty array dependency from create clefs function

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    24064a4 View commit details
    Browse the repository at this point in the history

  27. Reduce memory usage for penalties array (clef changes)

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    d09968d View commit details
    Browse the repository at this point in the history

  28. Refactoring of filterTuplets: extract findCommonIndexes function

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    dea29ff View commit details
    Browse the repository at this point in the history

  29. Refactoring of filterTuplets: extract findTupletIntervals function

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    44a0964 View commit details
    Browse the repository at this point in the history

  30. Remove check for empty tuplets (it's done earlier)

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    89aa2a6 View commit details
    Browse the repository at this point in the history

  31. Refactoring of tuplet error setting for shorter code

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    af84af8 View commit details
    Browse the repository at this point in the history

  32. Refactoring of filterTuplets: extract findBestTuplets function

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    ca4433e View commit details
    Browse the repository at this point in the history

  33. Refactoring of tuplet filtering functions for clearer code

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    aca734d View commit details
    Browse the repository at this point in the history

  34. Fix permutation limit condition

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    4f0c713 View commit details
    Browse the repository at this point in the history

  35. Recursively find common tuplet groups to reduce permutation count

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    a6e9c1c View commit details
    Browse the repository at this point in the history

  36. Fix chords^2 running time for doNotesOverlap debug function

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    b8c53b6 View commit details
    Browse the repository at this point in the history

  37. New - faster tuplet filtering algorithm (instead of permutations)

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    2e14731 View commit details
    Browse the repository at this point in the history

  38. Remove sorting of tuplets because there was no bonus speed

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    09377ea View commit details
    Browse the repository at this point in the history

  39. Remove saved tuplet indexes because tuplet ordering is unchanged

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    5b3ddce View commit details
    Browse the repository at this point in the history

  40. More full recursive algorithm for tuplet filtering

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    79f9c99 View commit details
    Browse the repository at this point in the history

  41. Remove not necessary function argument

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    d7235ae View commit details
    Browse the repository at this point in the history

  42. Refactoring of tuplet filtering code

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    092118c View commit details
    Browse the repository at this point in the history

  43. Always use max tuplet count possible - fix mtest

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    9ac8bf5 View commit details
    Browse the repository at this point in the history

  44. Filter group of totally common tuplets differently

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    21ad626 View commit details
    Browse the repository at this point in the history

  45. Refactoring: extract prepare voice intervals function

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    5f49b81 View commit details
    Browse the repository at this point in the history

  46. Fix quantization scheme

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    38a3cf1 View commit details
    Browse the repository at this point in the history

  47. Move check for emptiness into Q_ASSERT

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    407e5d1 View commit details
    Browse the repository at this point in the history

  48. Off time instead of note length

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    fca1664 View commit details
    Browse the repository at this point in the history

  49. Add const

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    9ec893c View commit details
    Browse the repository at this point in the history

  50. Information for quantization is taken from tuplets search stage

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    63e19bf View commit details
    Browse the repository at this point in the history

  51. Fix first chord in tuplet that was placed outside the tuplet

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    d6b7e69 View commit details
    Browse the repository at this point in the history

  52. Fix tuplet note staccato offTime

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    8e48cbd View commit details
    Browse the repository at this point in the history

  53. Move overlapping notes check function

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    8ca7067 View commit details
    Browse the repository at this point in the history

  54. Move variable reset under if condition

    @trig-ger
    trig-ger committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    d8e07ad View commit details
    Browse the repository at this point in the history