[MU3 Backend] ENG-42 & ENG-14: MusicXML Barlines fixes

[iveshenry18]

Resolves: ENG-42: Final barlines must be joined over grand staff, and ENG-14: Double barlines faulty on grand staff

Fixes issues with final barlines and other barlines in grand staves. The former is fixed with a port from 3080d21.

• I signed CLA
• I made sure the code in the PR follows the coding rules
• I made sure the code compiles on my machine
• I made sure there are no unnecessary changes in the code
• I made sure the title of the PR reflects the core meaning of the issue you are solving
• I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
• I made sure the commit message title starts with "fix #424242:" if there is a related issue
• I created the test (mtest, vtest, script test) to verify the changes I made

[wizofaus]

Where is testSystemBrackets3_ref.mscx loaded and verified?
I can't find "SystemBrackets3" anywhere in the source code at all.

UPDATE: it isn't in the master/MU4 branch, only MU3.6

[iveshenry18]

Where is testSystemBrackets3_ref.mscx loaded and verified?
I can't find "SystemBrackets3" anywhere in the source code at all.

UPDATE: it isn't in the master/MU4 branch, only MU3.6

That's correct; these changes are only on this specific branch (3.6.2_backend) for now.

[wizofaus]

Is there any reason not to merge everything on 3.6.2_backend to master then? I've updated my PR with some of these changes but not all. Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Henry Ives ***@***.***> Sent: Thursday, June 3, 2021 5:28:16 AM To: musescore/MuseScore ***@***.***> Cc: wizofaus ***@***.***>; Comment ***@***.***> Subject: Re: [musescore/MuseScore] [MU3 Backend] ENG-42 & ENG-14: MusicXML Barlines fixes (#8175) Where is testSystemBrackets3_ref.mscx loaded and verified? I can't find "SystemBrackets3" anywhere in the source code at all. UPDATE: it isn't in the master/MU4 branch, only MU3.6 That's correct; these changes are only on this specific branch (3.6.2_backend) for now. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#8175 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABI5UAKY6DDQGDFBGJ33A5TTQ2A5BANCNFSM45QVBB5Q>.

[iveshenry18]

So far this branch does include at least one commit containing code exclusive to this task that does not go in master, but other than that, porting all these to master is indeed the eventual plan as far as I know. You are welcome to do that with any commit you see fit, provided you double-check for any regressions.

[wizofaus]

Does "Fetch Upstream" not work for branches other than 'master'? I just did it on my fork but my 3.6.2_backend branch didn't get updated, I had to explicitly merge from the original musescore remote to get the latest changes.

[Jojo-Schmitz]

git fetch upstream (actually git fetch musescore as that's the name for my upstream repo, an idiosyncrasy of GitHub Desktop) does work for me