Guitar slide, hammeron and pulloff base class #8180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laturetab
force-pushed
the
slurando
branch
2 times, most recently
from
e4485ba
to
7e5c45b
Compare
src/libmscore/chord.cpp
Outdated
| // layout slurando | ||
| for (const Spanner* sp : note->spannerBack()) { | ||
| if (sp->isSlurando()) { | ||
| qreal d = ((Slurando*)sp)->layoutWidth(note, this); |
There was a problem hiding this comment.
Can't you use toSlurando() here (you added it after all, so why not using it too)?
src/libmscore/chord.cpp
Outdated
| // layout Slurando | ||
| for (const Spanner* sp : note->spannerBack()) { | ||
| if (sp->isSlurando()) { | ||
| qreal d = ((Slurando*)sp)->layoutWidthTab(note, this); |
|
why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base class (Slurando) to track guitar slide, hammer-on and pull-offs. Save/loads information to/from mscx/mscz format. Draws slur between 2 notes like a tie, with optional text centered on slur or below staff (e.g. "P", "H", "Sl.") Currently does not have any UI and is not created by any importers, however it should work well with MusicXml and GuitarPro. Derived from tie.cpp and contains a lot of duplicate code. I will create a 2nd PR to remove the duplicate code if this class makes it into master.