Added changing of clef when switching to a different instrument #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't try it yet. But my first impression is that it's just a partial solution since the transposing/concert clef of the new instrument will not be used. So if a user is viewing the score, change the instrument, and then switch to concert pitch, the clef will not be the one of the new instrument. Again, I need to test it. |
|
Rebase needed... |
|
And we'd still want to test behavior for transposing instruments, in terms of the separate clefs used for concert pitch on versus off. |
|
This PR is now old and it was incomplete. I close it. |
|
Hmm. I hope somebody else can fix https://musescore.org/en/node/114501, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code that changes the clef, when an instrument has been changed in the staff properties.
Unfortunately, the optional template is not yet available, so I had to go with std::pair, where the first boolean is true when the instrument has been changed, and the second member is the actual clef.