-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU3 Backend] ENG-6: Add partial default-y support #8237
Merged
vpereverzev
merged 1 commit into
musescore:3.6.2_backend
from
iveshenry18:ENG-6-default-y
Jun 4, 2021
Merged
[MU3 Backend] ENG-6: Add partial default-y support #8237
vpereverzev
merged 1 commit into
musescore:3.6.2_backend
from
iveshenry18:ENG-6-default-y
Jun 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Jun 3, 2021
vpereverzev
reviewed
Jun 3, 2021
3861fcf
to
0808077
Compare
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected
0808077
to
13e6c0f
Compare
@vpereverzev thank you again for the comments! I've applied them and pushed the amended commit. |
vpereverzev
approved these changes
Jun 4, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jun 28, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 1, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Due to inconsistencies in the MusicXML spec and its implementation with regards to default-y and relative-y, precise implementation is not currently reasonable. Instead, this commit adds two essential functions which provide a sufficient amount of support for the vertical layout of direction elements: - In the case that the placement (above/below) isn't specified, this is inferred by the value of default-y + relative-y (here called totalY). - Rather than being added to their Segment upon read, direction elements with a default-y or relative-y specified are collected, sorted by totalY, then added to their Segment in ascending order. Autoplace places elements in the order they are added, so this allows at least the ordering of default-y and relative-y to be respected Duplicate of musescore#8237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: ENG-6: default-y attribute not respected
Due to inconsistencies in the MusicXML spec and its implementation
with regards to default-y and relative-y, precise implementation is
not currently reasonable. Instead, this commit adds two essential
functions which provide a sufficient amount of support for the vertical
layout of direction elements:
this is inferred by the value of default-y + relative-y (here called
totalY).
with a default-y or relative-y specified are collected, sorted by
totalY, then added to their Segment in ascending order. Autoplace places
elements in the order they are added, so this allows at least the
ordering of default-y and relative-y to be respected