Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-19: Correctly omit instrument names #8326

Merged
merged 2 commits into from
Jun 23, 2021
Merged

[MU3 Backend] ENG-19: Correctly omit instrument names #8326

merged 2 commits into from
Jun 23, 2021

Commits on Jun 22, 2021

  1. ENG-19: Correctly omit instrument names 

    Previously, instrument names were erroneously included based on the
MIDI instrument associated with a part, even when print-object="no" was
specified in the XML. This commit makes sure that those MIDI part names
are overridden in the case that print-object="no" is specified.
    @iveshenry18
    iveshenry18 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    24d892e View commit details
    Browse the repository at this point in the history

  2. Add inferencing for incorrect part names 

    Sibelius seems to export part names as "P#" rather than specifying
print-object="no". This commit adds handling of this case, omitting
part names of the (regex) form "$P[0-9]+^".
    @iveshenry18
    iveshenry18 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    5cadfae View commit details
    Browse the repository at this point in the history