Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-23: Infer transpositions for guitar staves #8358

Merged
merged 1 commit into from Jun 29, 2021
Merged

[MU3 Backend] ENG-23: Infer transpositions for guitar staves #8358

merged 1 commit into from Jun 29, 2021

Conversation

iveshenry18
Copy link
Contributor

Resolves: ENG-23: Guitar notated in wrong octave

Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition when transpositions aren't supported. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the written
pitch, called _inferredTranspose.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@Jojo-Schmitz
Copy link
Contributor

rebase needed

@iveshenry18
ENG-23: Infer transpositions for Guitar staves
aa23c4a 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.
@iveshenry18
Copy link
Contributor Author

Rebased!

@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jun 29, 2021
Closed
@vpereverzev vpereverzev merged commit 5692d4c into musescore:3.6.2_backend Jun 29, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 30, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
210ccd5 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning
@iveshenry18 iveshenry18 mentioned this pull request Jun 30, 2021
Merged
8 tasks
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
676563a 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 5, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
169fa80 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 6, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
3e4c6b6 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
e8294f7 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
98cd160 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
a5cdcf3 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
09aaeda 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
0397ac4 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
eadc1ba 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
12645ed 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
98f89eb 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
e6c7a1a 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
e114a64 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
a39e098 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
b7ffa49 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
564cde3 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
3973427 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
45fdb51 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
d0588d6 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
ef992bf 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
b23f7d0 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@iveshenry18 @Jojo-Schmitz
ENG-23: Infer transpositions for Guitar staves
82a05e9 
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the *written*
pitch, called `_inferredTranspose`.

Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jojo-Schmitz Jojo-Schmitz Jojo-Schmitz left review comments

@oktophonie oktophonie oktophonie approved these changes

@vpereverzev vpereverzev vpereverzev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iveshenry18 @Jojo-Schmitz @oktophonie @vpereverzev