New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-5: Infer Credits #8413

Merged

vpereverzev merged 2 commits into musescore:3.6.2_backend from iveshenry18:ENG-5-infer-subtitle

Jun 28, 2021

Contributor

iveshenry18 commented Jun 23, 2021 •

edited

Resolves: ENG-5: Subtitle incorrectly rendered as Stave Text

Dolet commonly exports credit text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made


          ENG-5: infer subtitles

d406c96

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

iveshenry18 changed the title ~~[MU3 Backend] ENG-5: Infer Subtitles~~ [MU3 Backend] ENG-5: Infer Credits


          ENG-5: Change inferred credits to composer

1ecbf11

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

iveshenry18 force-pushed the ENG-5-infer-subtitle branch from 9be8ad5 to 1ecbf11 Compare

June 23, 2021 21:43

oktophonie approved these changes

View reviewed changes

vpereverzev approved these changes

View reviewed changes

vpereverzev merged commit b776c1f into musescore:3.6.2_backend

Jojo-Schmitz mentioned this pull request

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

d7bb9f6

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

30f6ff3

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

8ab0fcf

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

3d0f666

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

79032b4

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

204bcc2

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

702f5b8

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

2835bb0

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

73c7b7c

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

b80882f

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

b07b752

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

0d457cd

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

1c782e6

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

9712ca3

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

989cb9b

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

f99155d

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

2578e79

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

4190fed

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

11cca27

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

bd065d7

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

7c370f7

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

6def012

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-5

e262156

See musescore#8413, part 2, issue possibly caused by another commit though

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

81aaea4

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

88cbf08

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-5

6415ae7

See musescore#8413, part 2, issue possibly caused by another commit though

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

51c73cc

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

cac1515

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-5

7a5830f

See musescore#8413, part 2, issue possibly caused by another commit though

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

dcd5bfc

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

0ce3694

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-5

11a3f3d

See musescore#8413, part 2, issue possibly caused by another commit though

Jojo-Schmitz mentioned this pull request

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

758762d

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

9bb4f85

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-5

f91713e

See musescore#8413, part 2, issue possibly caused by another commit though

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

e82abd8

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

307999c

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-5

11c74b4

See musescore#8413, part 2, issue possibly caused by another commit though

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

49b973e

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

535f9e2

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-5

cd1c3a0

See musescore#8413, part 2, issue possibly caused by another commit though

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

ae61a54

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

c9be574

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-5

6d0e18b

See musescore#8413, part 2, issue possibly caused by another commit though

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-5

f8ed185

See musescore#8413, part 2, issue possibly caused by another commit though

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-5

8c52e96

See musescore#8413, part 2, issue possibly caused by another commit though

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-5

d75a7dd

See musescore#8413, part 2, issue possibly caused by another commit though

Jojo-Schmitz mentioned this pull request

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: infer subtitles

786f230

Dolet commonly exports subtitle text as staff text attached to a beat
near the beginning of the score. This commit adds regex-based
inferencing for this case, adding the text to a new subtitle in the
beginning VBox of the score.

Duplicate of musescore#8413, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-5: Change inferred credits to composer

Rather than inferring credit text as a subtitle, it is now converted
to a composer. Additional, some space is added to the in the case of
long credits.

Duplicate of musescore#8413, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-5

dabc58b

See musescore#8413, part 2, issue possibly caused by another commit though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment