Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-20: Add support for "wavy" type brackets #8480

Merged
merged 1 commit into from Jul 5, 2021
Merged

[MU3 Backend] ENG-20: Add support for "wavy" type brackets #8480

merged 1 commit into from Jul 5, 2021

Conversation

iveshenry18
Copy link
Contributor

Resolves: ENG-20: Wiggle lines incorrectly imported

Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@iveshenry18
ENG-20: Add support for "wavy" type brackets
4728006 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jul 1, 2021
Closed
@vpereverzev vpereverzev merged commit 7e0d639 into musescore:3.6.2_backend Jul 5, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 6, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
6876b71 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
20448a7 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
5e7c022 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
5f68086 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
c594003 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
7866c57 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
8fada51 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
ae0a3a3 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
5515754 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
a8830dc 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
87a5b41 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
a58bc33 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
e21d7c3 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
449cdfa 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
15515d1 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
4ecf7cd 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
ec53ce2 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
e9accb7 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
cb05ae4 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@iveshenry18 @Jojo-Schmitz
ENG-20: Add support for "wavy" type brackets
461254b 
Previously, brackets with line-type "wavy" were unsupported. This commit
adds handling for them by creating a Trill line of type PRALLPRALL_LINE,
which best visually matches the examples in the MusicXML spec. This
required some fairly involved changes to the structure of
MusicXMLParserPass2::bracket().

Duplicate of musescore#8480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oktophonie oktophonie oktophonie approved these changes

@vpereverzev vpereverzev vpereverzev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iveshenry18 @oktophonie @vpereverzev