[MU3] Fix #322759: Inputing Ottava Bassa via menu or shortcut shows it above staff #8515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
commented
Jul 4, 2021
| @@ -1414,6 +1414,7 @@ PalettePanel* MuseScore::newLinesPalettePanel() | |||
| ottava = new Ottava(gscore); | |||
| ottava->setOttavaType(OttavaType::OTTAVA_22MB); | |||
| ottava->setLen(w); | |||
| ottava->setPlacement(Placement::BELOW); | |||
There was a problem hiding this comment.
May not be needed, certainly not for the issue at hand, but I found this to be pretty inconsistent, at least.
Jojo-Schmitz
commented
Jul 4, 2021
| @@ -1435,6 +1435,10 @@ void Score::cmdAddOttava(OttavaType type) | |||
| cr2 = cr1; | |||
| Ottava* ottava = new Ottava(this); | |||
| ottava->setOttavaType(type); | |||
| if (type == OttavaType::OTTAVA_8VB/* || type == OttavaType::OTTAVA_15MB || type == OttavaType::OTTAVA_22MB*/) { | |||
There was a problem hiding this comment.
No need to check for OttavaType::OTTAVA_15MB and OttavaType::OTTAVA_22MB, as there's no shortcut for those
Jojo-Schmitz
commented
Jul 4, 2021
| @@ -1453,7 +1457,10 @@ void Score::cmdAddOttava(OttavaType type) | |||
|
|
|||
| Ottava* ottava = new Ottava(this); | |||
| ottava->setOttavaType(type); | |||
|
|
|||
| if (type == OttavaType::OTTAVA_8VB/* || type == OttavaType::OTTAVA_15MB || type == OttavaType::OTTAVA_22MB*/) { | |||
This was referenced Jul 4, 2021
|
What's branch 3.x used for? I thought there weren't going to be any more 3.x versions released (only the backend for doing online conversions etc.) |
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 5, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 6, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 13, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
|
See #9000 |
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
…e staff Duplicate of musescore#8515, resp. backport of musescore#8516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/322759
PR for master in #8516 (merged already)