New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-64: Fix layout overflows in XML import #8613

Merged

vpereverzev merged 1 commit into musescore:3.6.2_backend from iveshenry18:ENG-64-system-overflow

Jul 28, 2021

Contributor

iveshenry18 commented Jul 14, 2021

Resolves: ENG-64: Systems overflow and cause page layout issues

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made

Jojo-Schmitz mentioned this pull request

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed

iveshenry18 changed the title ~~ENG-64: Fix layout overflows in XML import~~ [MU3 Backend] ENG-64: Fix layout overflows in XML import

oktophonie approved these changes

View reviewed changes

vpereverzev approved these changes

View reviewed changes


          ENG-64: Fix layout overflows in XML import

19e59b4

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

iveshenry18 force-pushed the ENG-64-system-overflow branch from f85084e to 19e59b4 Compare

July 20, 2021 20:39

vpereverzev merged commit 6a2cfb1 into musescore:3.6.2_backend

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

5262fd6

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

38f656e

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

254e351

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

c3c07cb

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

653d72e

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

073e1c4

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz mentioned this pull request

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

04d68f9

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

d2a4948

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-64

4b6e5f1

See musescore#8613
Not sure why this is needed all of a sudden?

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-64

See musescore#8613
Not sure why this is needed all of a sudden?

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-64

663b2cb

See musescore#8613
Not sure why this is needed all of a sudden?

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

b26a093

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-64

a3d06ab

See musescore#8613
Not sure why this is needed all of a sudden?

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

9b14d16

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-64

5abef0c

See musescore#8613
Not sure why this is needed all of a sudden?

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-64

8ca05c4

See musescore#8613
Not sure why this is needed all of a sudden?

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

f777d89

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-64

568e424

See musescore#8613
Not sure why this is needed all of a sudden?

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

c014445

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-64

faee60c

See musescore#8613
Not sure why this is needed all of a sudden?

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

de6c888

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-64

c17e365

See musescore#8613
Not sure why this is needed all of a sudden?

Jojo-Schmitz mentioned this pull request

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-64: Fix layout overflows in XML import

ecee642

Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.

Duplicate of musescore#8613

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix mtest related to ENG-64

0a6e0be

See musescore#8613
Not sure why this is needed all of a sudden?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment