Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3 Backend] ENG-18-adjacent Remove left FretDiagram spacer if first beat of measure #8619

Conversation

iveshenry18
Copy link
Contributor

Resolves: ENG-18: Fretboard diagrams need much improvement

This commit changes the spacer code in ChordRest::shape to prevent a
left space from being created in the first beat of a measure. This
spacer was causing an unnecessary gap between the barline and the first
beat.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

This commit changes the spacer code in ChordRest::shape to prevent a
left space from being created in the first beat of a measure. This
spacer was causing an unnecessary gap between the barline and the first
beat.
@iveshenry18
Copy link
Contributor Author

Folded into #8636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant