New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-65: Volta print-object not respected #8622

Merged

vpereverzev merged 2 commits into musescore:3.6.2_backend from iveshenry18:ENG-65-multi-volta

Jul 20, 2021

Contributor

iveshenry18 commented Jul 15, 2021 •

edited

Resolves: ENG-65: Voltas are created on multiple staves

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Finally, it adds handling for simply ignoring voltas that are both hidden
AND redundant (i.e. there is an existing non-hidden volta in a different
staff).

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made


          ENG-65: Volta print-object not respected

79e0731

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

iveshenry18 force-pushed the ENG-65-multi-volta branch from 104500b to 79e0731 Compare

July 15, 2021 00:43

Jojo-Schmitz mentioned this pull request

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed


          ENG-65: Remove hidden redundant voltas

97d37e7

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

iveshenry18 marked this pull request as ready for review

July 15, 2021 22:21

oktophonie approved these changes

View reviewed changes

vpereverzev approved these changes

View reviewed changes

vpereverzev merged commit 9ca7a81 into musescore:3.6.2_backend

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

89801d5

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

b1e1946

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

ea975ff

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

6f9d5ba

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

36152cb

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

3fc7edf

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

6bbf694

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

444e23d

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

0f26f43

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

8f456b1

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

24196d4

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

e9d1366

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

cd651a1

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

0bffe70

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

7a6855e

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

d539017

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

dea69bd

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

be5ed0f

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

6a6be18

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

5a27b44

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

60056b2

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

6e744ed

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

0cb8694

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

b334bf6

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

6e8b512

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

faa363b

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

7fecd46

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

f2e689c

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz mentioned this pull request

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

3666bb6

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

307aa41

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

9d3e8e5

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

2c6f40f

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

2668b9a

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

7a3e919

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

0d0eec6

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz referenced this pull request


          Fix #329608: [MusicXML export] custom ending text not exported

a24083a

Export the volta text to the MusicXML ending element, allowing custom text such as "1-3".

Backport of #10623, plus 2 more mtest fixes

Jojo-Schmitz mentioned this pull request

Fix #329608: [MusicXML export] custom ending text not exported #10623

Merged

8 tasks

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

23bb808

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

1e06f88

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

Jojo-Schmitz mentioned this pull request

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Volta print-object not respected

d1089a2

Dolet tends to export voltas on every part, then hide all but one.
Previously, these would all be imported and not hidden. This commit
hides voltas when print-object="no".

Additionally, it adds handling for only exporting voltas in the staff
they are in, as previously one volta was exported for each part, despite
the volta only existing on one part.

Duplicate of musescore#8622, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-65: Remove hidden redundant voltas

1099c0e

Since Dolet exports unnecessary hidden voltas, we can discard these
rather than import them as hidden elements (that is, as long as they
are both hidden AND redundant).

Duplicate of musescore#8622, part 2

asattely mentioned this pull request

Ignore redundant voltas and hide voltas with print-object="no" on mxml import #16714

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment