New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-71: Infer more Dolet word export quirks #8651

Merged

vpereverzev merged 2 commits into musescore:3.6.2_backend from iveshenry18:ENG-71-word-quirks

Aug 5, 2021

Contributor

iveshenry18 commented Jul 17, 2021

Resolves: ENG-71: Staff Text export quirks can be easily replaced: NmiCmi = N.C. ; $ = segno

This PR adds two commits which make some import inferences to correct for Dolet text export quirks.

The first of these fixes a strange "NmiCmi" direction that is sometimes exported instead of a "N.C." chord symbol.

The second adds $ and Ø symbols to the map in text2syms, resulting in these being translated to segno and coda symbols on read.

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made

iveshenry18 added 2 commits

July 17, 2021 12:01


          ENG-71: Infer NmiCmi to N.C.

aca2536

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.


          ENG-71 Infer $ and Ø to segno and coda on read

ca78320

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Jojo-Schmitz mentioned this pull request

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed

oktophonie approved these changes

View reviewed changes

vpereverzev approved these changes

View reviewed changes

vpereverzev merged commit 412c137 into musescore:3.6.2_backend

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

b73b542

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

068e63a

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

7888a9a

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

021f1e9

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duiplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

02586e0

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

688137a

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duiplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

d7968ad

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

2e8e641

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duiplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

1f4cda7

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

3ade30c

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duiplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

5241f47

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

644ccc9

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duiplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

1fd6885

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

7752c12

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duiplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

1bfd4e4

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

2b139b0

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duiplicate of musescore#8651, part 2

Jojo-Schmitz mentioned this pull request

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

2768a8f

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

0e2bcf2

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duiplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

c4fa336

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

56e12c4

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

32a2d87

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

dbaf56c

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

437ace2

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

ed5428f

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

ea0b4d5

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

261da28

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

d005a60

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

a0d589f

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

44ee2ad

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

4594ae4

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duplicate of musescore#8651, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

bc93506

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

fcc1c20

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duplicate of musescore#8651, part 2

Jojo-Schmitz mentioned this pull request

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71: Infer NmiCmi to N.C.

504e278

Dolet exports some N.C. chord symbols as a direction with a words
element containing "NmiCmi". This adds a simple inference to handle
that.

Duplicate of musescore#8651, part 1, plus a compile fix (adding a missing
paramenter,`_isBold`)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-71 Infer $ and Ø to segno and coda on read

390283a

Dolet seems to occasionally export $ and Ø where segno and coda symbols
ought to be exported in lyrics and staff text. This commit adds those as
special cases to the map in text2syms.

Duplicate of musescore#8651, part 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment