Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3] Instruments recognition fix #8866

Merged
merged 1 commit into from Aug 18, 2021
Merged

[MU3] Instruments recognition fix #8866

merged 1 commit into from Aug 18, 2021

Conversation

RomanPudashkin
Copy link
Contributor

No description provided.

@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Aug 16, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 16, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
0c825e8 
…bbreviation tag

Duplicate of musescore#8866, part 1
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 16, 2021
@RomanPudashkin @Jojo-Schmitz
small optimization
625222e 
Duplicate of musescore#8866, part 2
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 16, 2021
@RomanPudashkin @Jojo-Schmitz
implemented the case insensitive search
492e65b 
Duplicate of musescore#8866, part 3
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Aug 16, 2021 •
edited

This seems to result in issues with "pluck.guitar.nylon-string" to get missdetected as "metal.steel-drums" and "drum.group.set" as "metal.tamtam" in tst_compat114
and "voice.tenor" to get missdetected as "wind.flutes.gemshorn" tst_compat206
and "oboe" to get missdetected as "piccolo-oboe" in tst_instrumentchange
and "guitar-nylon-treble-clef" as "guitar-steel-drums" and "bass" as "bass-flute" and "soprano" as "soprano-flute". in tst_mxml_io.

Check https://github.com/Jojo-Schmitz/MuseScore/runs/3342257045

@RomanPudashkin RomanPudashkin marked this pull request as draft August 16, 2021 21:07
@RomanPudashkin
Copy link
Contributor Author

@Jojo-Schmitz

For some reason, those tests fail even without my changes. It seems that something has been broken in the 3.6.2_backend branch

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Aug 17, 2021 •
edited

On my branch the tests passed before having applied your changes but not after, and being related to instrument names your changes are the most likely cause, actually the only likely cause.
But yes, some of the backend changes broke mtests, and I had to fix them in my branch, some without really knowing what the desired outcome might be...

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 18, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
f6cccc8 
…bbreviation tag

Duplicate of musescore#8866, part 1
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 18, 2021
@RomanPudashkin @Jojo-Schmitz
small optimization
75b220a 
Duplicate of musescore#8866, part 2
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 18, 2021
@RomanPudashkin @Jojo-Schmitz
implemented the case insensitive search
cc49e95 
Duplicate of musescore#8866, part 3
@RomanPudashkin RomanPudashkin marked this pull request as ready for review August 18, 2021 09:34
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 18, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
c5f42ea 
…bbreviation tag

Duplicate of musescore#8866
@Eism Eism merged commit 0424e4f into musescore:3.6.2_backend Aug 18, 2021
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Aug 18, 2021 •
edited

FWIW: I can approve this too, the mtests work again, see https://github.com/Jojo-Schmitz/MuseScore/runs/3359680621
(Just needed a bit more time to check than @Eism :-) )

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 18, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
3f0c7bd 
…bbreviation tag

Duplicate of musescore#8866
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
2d3f147 
…bbreviation tag

Duplicate of musescore#8866
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
6ebafbc 
…bbreviation tag

Duplicate of musescore#8866
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
8868d70 
…bbreviation tag

Duplicate of musescore#8866
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
a1f965d 
…bbreviation tag

Duplicate of musescore#8866
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
ac33636 
…bbreviation tag

Duplicate of musescore#8866
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
51fdb01 
…bbreviation tag

Duplicate of musescore#8866
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 9, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
4c984c3 
…bbreviation tag

Duplicate of musescore#8866
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
d63ce93 
…bbreviation tag

Duplicate of musescore#8866
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
3b9c546 
…bbreviation tag

Duplicate of musescore#8866
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 26, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
2eab5de 
…bbreviation tag

Duplicate of musescore#8866
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 29, 2021
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
7c56c6f 
…bbreviation tag

Duplicate of musescore#8866
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
e2ed6bd 
…bbreviation tag

Duplicate of musescore#8866
@RomanPudashkin RomanPudashkin deleted the instruments_recognition_fix branch February 3, 2023 14:04
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@RomanPudashkin @Jojo-Schmitz
improved the instruments recognition algorithm using the instrument-a…
3b3c6cd 
…bbreviation tag

Duplicate of musescore#8866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jojo-Schmitz Jojo-Schmitz Jojo-Schmitz left review comments

@Eism Eism Eism approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RomanPudashkin @Jojo-Schmitz @Eism