[MU4] ENG-97: Dashed lines that cross systems become continuous #8903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a) don't merge, but pull (and push -f), to avoid those merge commits (fixed meanwhile) |
yup, that's my mistake, sorry! |
|
And shouldn't those "ENG-##" pull requests (also) go to the |
|
All previous were. Here though I'm not even sure which problem it is trying to solve? Like how to reproduce the issue, in master and/or 3.x |
It's a libmscore issue, where a dashed line with a centered hook (such as let ring or palm mute) would display as solid when continuing to the next system. |
|
Ah! And indeed 3.6.2 (and most probably 3.6.2_backend too) and 3.x have the same issue. Edit 1: Only that code change doesn't fix it there (not tested it on master yet). Edit 2: Actually it does, I've just been too stupid to apply it properly... |
Jojo-Schmitz
approved these changes
Aug 23, 2021
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 23, 2021
The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system)
Jojo-Schmitz
approved these changes
Aug 23, 2021
|
Also fixes https://musescore.org/en/node/307982 |
|
ENG-* changes from now on are for master only. |
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 24, 2021
…ore system break Also ENG-97: Dashed lines that cross systems become continuous The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
oktophonie
approved these changes
Aug 26, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 26, 2021
…ore system break Also ENG-97: Dashed lines that cross systems become continuous The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
…ore system break Also ENG-97: Dashed lines that cross systems become continuous The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
…ore system break Also ENG-97: Dashed lines that cross systems become continuous The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
…ore system break Also ENG-97: Dashed lines that cross systems become continuous The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
…ore system break Also ENG-97: Dashed lines that cross systems become continuous The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 9, 2021
…ore system break Also ENG-97: Dashed lines that cross systems become continuous The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
…ore system break Also ENG-97: Dashed lines that cross systems become continuous The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
…ore system break Also ENG-97: Dashed lines that cross systems become continuous The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2021
…ore system break Also ENG-97: Dashed lines that cross systems become continuous The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 29, 2021
…ore system break Also ENG-97: Dashed lines that cross systems become continuous The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
…ore system break Also ENG-97: Dashed lines that cross systems become continuous The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
…ore system break Also ENG-97: Dashed lines that cross systems become continuous The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system) Backport of musescore#8903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that MuseScore was attempting to draw the hook with the solid line style even when there was no hook to be drawn (because the line continued to the next system)