Assorted nitpicks #908
Merged
Assorted nitpicks #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created by vim and QtCreator
same as the one in the correspoding .h file
translating doesn't work (not this way at least) and won't happen anyway as the translation mechanism is set up only later in the code, after the use of the usage() function. Remove the mention of an option that (no longer?) exists
and add two missing ones. Also remove a 'plugin comment' from a .cpp file, where it doesn't serve any purpose anyway (but at first tricked me into believing this were the the culprit for the duplicate)
unified diffs are much easier to read
and fix indentation
reformatting, removing some comments that are irrelevant to plugin framework in a way that DoxyGen should still find them, documenting the enums and fully qualify all types that are specific to MuseScore,
which QtCreator's syntax check complains about (but not the compiler)
as the only Q_ENUMS() not accompnied by corresponding a Q_DECLARE_METATYPE()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the branches name or this PR's title: it meanwhile became much more than just nitpicks ;-)