fix #9007 - Invisible key/time signatures having adverse effect on spacing #9137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asattely
force-pushed
the
invis-key-timesigs
branch
from
2fe4fd6
to
9c77d98
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 16, 2021
…spacing Backport of musescore#9137 (needs parts of musescore#9137)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 16, 2021
…spacing Backport of musescore#9137 (needs parts of musescore#9137)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 16, 2021
…spacing Backport of musescore#9137 (needs parts of musescore#9137)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 16, 2021
…spacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
…spacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
…spacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
…spacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
…spacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
…spacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
…spacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
…spacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 20, 2021
…spacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 20, 2021
(Very partial) backport of musescore#9068, the rest is too large for too litle benefit (mainly due to the missing UI) and also requires C++17.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 20, 2021
…pacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 21, 2021
(Very partial) backport of musescore#9068, the rest is too large for too litle benefit (mainly due to the missing UI) and also requires C++17.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 21, 2021
…pacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 22, 2021
(Very partial) backport of musescore#9068, the rest is too large for too litle benefit (mainly due to the missing UI) and also requires C++17.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 22, 2021
…pacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
(Very partial) backport of musescore#9068, the rest is too large for too litle benefit (mainly due to the missing UI) and also requires C++17.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
…pacing Backport of musescore#9137 (needs parts of musescore#9068)
|
Checked #9007 on Win10, Mac11.13.1, Linux Mint 20.2 - FIXED Please merge into master (@RomanPudashkin ) |
RomanPudashkin
approved these changes
Sep 23, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 24, 2021
(Very partial) backport of musescore#9068, the rest is too large for too litle benefit (mainly due to the missing UI) and also requires C++17.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 24, 2021
…pacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2021
(Very partial) backport of musescore#9068, the rest is too large for too litle benefit (mainly due to the missing UI) and also requires C++17.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2021
…pacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 29, 2021
(Very partial) backport of musescore#9068, the rest is too large for too litle benefit (mainly due to the missing UI) and also requires C++17.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 29, 2021
…pacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 3, 2021
(Very partial) backport of musescore#9068, the rest is too large for too litle benefit (mainly due to the missing UI) and also requires C++17.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 3, 2021
…pacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 7, 2021
(Very partial) backport of musescore#9068, the rest is too large for too litle benefit (mainly due to the missing UI) and also requires C++17.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 7, 2021
…pacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
(Very partial) backport of musescore#9068, the rest is too large for too litle benefit (mainly due to the missing UI) and also requires C++17.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
…pacing Backport of musescore#9137 (needs parts of musescore#9068)
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
(Very partial) backport of musescore#9068, the rest is too large for too litle benefit (mainly due to the missing UI) and also requires C++17.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
…pacing Backport of musescore#9137 (needs parts of musescore#9068)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #9007
There were a lot of TODO comments surrounding this issue, so it feels good to finally start calculating this stuff the correct way.
(hidden elements invisible on the left, visible on the right)
There is also code that needs to be fixed that concerns practice mode, but that can be fixed in a future issue that will involve a giant refactor of how practice mode works (because right now there's a lot of copy and pasted code)