Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent system left alignment #9277

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

Nick-Mazuk
Copy link
Contributor

@Nick-Mazuk Nick-Mazuk commented Sep 24, 2021

Resolves: #8968

Here's a brief overview:

  1. Aligns the left origins of systems
  2. When no staff names are present, it aligns the system to the left margin (putting brackets outside the margin)
  3. Adds new style settings instrumentNameOffset, which removes a few TODO items from the code
  4. Makes the behavior in number 2 configurable with a new style setting alignSystemToMargin

More details can be found in the issue itself.

@Nick-Mazuk
Copy link
Contributor Author

Nick-Mazuk commented Sep 24, 2021

Looks like the macOS build failed on CI. Looking at the details, it seems like the test setup failed, not the build itself. I can confirm on my MacBook Pro that this builds successfully on macOS.

@Nick-Mazuk Nick-Mazuk changed the title System left alignment Consistent system left alignment Sep 24, 2021
@Nick-Mazuk
Copy link
Contributor Author

Nick-Mazuk commented Sep 24, 2021

Noticed that @Jojo-Schmitz created a PR yesterday to fix the CI build issue on macOS. Rebased this PR to hopefully resolve this failed CI check.

Edit: It passes now!

@Jojo-Schmitz
Copy link
Contributor

That fix of mine was unrelated though.

@Nick-Mazuk
Copy link
Contributor Author

That fix of mine was unrelated though.

Ok. Well, the rebasing worked anyways.

Remove unused code path

fix codestyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MU4 Issue] Left origin of staves should be consistent throughout score
4 participants