Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #25579 : possible buffer overflow #961

Closed
wants to merge 1 commit into from

Conversation

AntonioBL
Copy link
Contributor

No description provided.

@lasconic
Copy link
Contributor

Why are you doing this here? It seems that this shouldn't happen right? If you encounter a file that crash MuseScore because of this, we should fix the file reading. If we are encountering a crash during layout in this code, then we should fix the layout code. By fixing the bug in this place, we would be hiding the actual cause of the bug and never be able to fix it.

@lasconic lasconic closed this Jun 17, 2014
@AntonioBL
Copy link
Contributor Author

With address sanitizer switched on (at compilation time), I cannot use MuseScore because of this buffer overflow, since it now happens also for new files. See http://musescore.org/en/node/25579#comment-105021
This was just a work-around to skip this problem and the behavior should be analogous to the one that happens in MuseScore without address sanitizer, since the undefined behavior would most probably give something random or 0.

@AntonioBL AntonioBL deleted the overflow branch August 7, 2014 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants