fix #318085: [MusicXML export] figuredBass xml export (multiple figur… #9730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 13, 2021
…es per note) Backport of musescore#9730
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 13, 2021
…es per note) Backport of musescore#9730
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 23, 2021
…es per note) Backport of musescore#9730
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 24, 2021
…es per note) Backport of musescore#9730
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 28, 2021
…es per note) Backport of musescore#9730
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 28, 2021
…es per note) Backport of musescore#9730
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 30, 2021
…es per note) Backport of musescore#9730
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 7, 2021
…es per note) Backport of musescore#9730
|
rebase needed |
|
Will do |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
…es per note) Backport of musescore#9730
lvinken
force-pushed
the
318085-multiple-figures-master
branch
2 times, most recently
from
f1f56ef
to
702fdb3
Compare
| @@ -0,0 +1,79 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 3.1 Partwise//EN" "http://www.musicxml.org/dtds/partwise.dtd"> | |||
There was a problem hiding this comment.
For the unit test to pass ;-)
<!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 4.0 Partwise//EN" "http://www.musicxml.org/dtds/partwise.dtd">
<score-partwise version="4.0">
There was a problem hiding this comment.
Thanks, indeed I forgot to update that file.
lvinken
force-pushed
the
318085-multiple-figures-master
branch
from
702fdb3
to
0d05036
Compare
RomanPudashkin
approved these changes
May 27, 2022
|
Please rebase your PR to the latest master |
lvinken
force-pushed
the
318085-multiple-figures-master
branch
from
0d05036
to
5a9ea42
Compare
|
Rebase done |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
…es per note) Backport of musescore#9730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es per note)
Resolves: https://musescore.org/en/node/318085
When figured bass elements have a duration shorter than the shortest note, they are exported to MusicXML with duration zero. Caused by function ExportMusicXml::calcDivisions(), which does not seem to take figured bass duration into account when calculating the divisions value. Added figured bass handling to calcDivisions().