fix #26516: crash on repitch #992
Conversation
|
Closing temporarily while I finish looking at the tie issue |
|
I think ties are working as well as they need to. Only ties between single note chords are handled; one sided ties and ties from or to multi-note chords are removed. My only concern is with how I am updating the tied-into notes. Currently, I copy pitch, tpc, tpc1, and tpc2 from the repitched note. It seems to work, including for transposing instruments, but the code could stand review. |
|
Nope, doesn't work with linked staves/parts - I need a better way of updating the tied-into notes. |
|
undoChangePitch does the same thing I was doing manually, but works with links. I think everything works correctly now. |
| if (replace) { | ||
| QList<Note*> notes = chord->notes(); |
There was a problem hiding this comment.
There is still a small issue with tie.
- Create a score with a quarter C tied to a quarter C
- Select the first one, enter note input, enter repitch
- move cursor to the second note, press D
--> Result : We see a C "tied" to a D
--> Expected result: not sure, maybe we need to make sure that user can't select the second note of a tie?
There was a problem hiding this comment.
Good catch! I think the best thing is to do what is done for up/down - automatically "rewinding" to the start of the tie at the beginning of the whole operation (and I can fix it in both places to not go into an infinite loop if a note is tied to itself).
Another possibility is to assume the user is doing this on purpose, and break the tie back from the initially selected note. But I think I'll try the first solution.
There was a problem hiding this comment.
On second thought, it seems the first solution may be more trouble than it's worth, plus it would raise questions about how to handle mutli-note chords anywhere in the chain. Much simpler and more predictable to simply break any tie into a note.
There was a problem hiding this comment.
I might as well get the ties working for MIDI too, and fix a couple of other issues with MIDI input on repitch (treatment of rests). Should have it ready by end of day.
| if (!addFlag) { | ||
| QList<Note*> notes = chord->notes(); |
There was a problem hiding this comment.
Can you add a comment here? Something like // in repitch mode only ties between single note chords are handled; one sided ties and ties from or to multi-note chords are removed.
Idem in the copy of the code, maybe with a reference to each other.
No description provided.