Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #299741 and #289446 - Improved horizontal spacing algorithm #9928

Merged
merged 18 commits into from Jan 28, 2022
Merged

Fix #299741 and #289446 - Improved horizontal spacing algorithm #9928

merged 18 commits into from Jan 28, 2022

Commits on Jan 24, 2022

  1. New spacing algorithm

    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    8290865 View commit details
    Browse the repository at this point in the history

  2. Removed commented lines

    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    a7ee2db View commit details
    Browse the repository at this point in the history

  3. code style corrections

    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    6ce473d View commit details
    Browse the repository at this point in the history

  4. more codestyle fixes 

    (I hope I'll get it right at some point)
    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    9afaf19 View commit details
    Browse the repository at this point in the history

  5. (much) Improved efficiency - Improved spacing in continuous view 

    By passing the shortest note of the system to computeMinWidth() (instead of computing it *inside* the method itself) we save thousands of unnecessary loops through the measures (especially when in continuos view). This required to change the definition of the method and each time it was called.
Side benefit: also improved the behaviour of spacing algorithm in continuos view.
    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    45b026f View commit details
    Browse the repository at this point in the history

  6. Further improvements 

    The 'minimum note distance' parameter now only affects notes at- or close to the minimum.

Implemented a more refined way to increase the default spacing of longer notes, to make sure they're not too narrow in the absence of shorter ones.
    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    8c0d69a View commit details
    Browse the repository at this point in the history

  7. Codestyle and utest fixes 

    Grabbed from Jojo (thanks!)
    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    ccd0819 View commit details
    Browse the repository at this point in the history

  8. More improvements 

    Implemented dynamic spacing slope. Smarter decisions on how many measures to fit on a system. Rewritten the whole measure stretch algorithm. Finally fixed the problem of bars with many accidentals being too wide.
    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    95d8f70 View commit details
    Browse the repository at this point in the history

  9. Further refinement and code cleaning 

    Renamed a couple of methods to better reflect what they do now. Deleted some unnecessary code.
    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    2d67210 View commit details
    Browse the repository at this point in the history

  10. Small bug fixed. Changed default minNoteDistance to 0.4sp. Codestyle … 

    …and utest fixes.
    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    bbfd1aa View commit details
    Browse the repository at this point in the history

  11. Undone the minNoteDistance change 

    Will be moved to a separate PR with other style changes by @oktophonie
    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    9b778f9 View commit details
    Browse the repository at this point in the history

  12. Fixed utest

    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    b14c9a6 View commit details
    Browse the repository at this point in the history

  13. Bug fix

    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    4d5645f View commit details
    Browse the repository at this point in the history

  14. Corrections and code improvement

    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    fb1ae3e View commit details
    Browse the repository at this point in the history

  15. More code improvements

    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    ad2ab0c View commit details
    Browse the repository at this point in the history

  16. More improvements

    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    523b6f4 View commit details
    Browse the repository at this point in the history

  17. Added some comments

    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    735421f View commit details
    Browse the repository at this point in the history

  18. (fixed error)

    @mike-spa
    mike-spa committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    e306ca6 View commit details
    Browse the repository at this point in the history