enable support for wide beams #9937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick-Mazuk
force-pushed
the
beam-level-spacing
branch
from
4a0f078
to
98ba466
Compare
This was referenced Dec 1, 2021
Merged
Nick-Mazuk
force-pushed
the
beam-level-spacing
branch
2 times, most recently
from
052be26
to
cdcd893
Compare
|
Will need to be rebased and refactored again once #9976 is merged as there will be merge conflicts |
Nick-Mazuk
force-pushed
the
beam-level-spacing
branch
2 times, most recently
from
b7af27c
to
c59ba2c
Compare
cbjeukendrup
reviewed
Dec 8, 2021
Nick-Mazuk
force-pushed
the
beam-level-spacing
branch
from
c59ba2c
to
4468b05
Compare
|
The vtests failed in an expected way. Part of this PR includes a minor bugfix where small notes (either because the staff is small or the note is small on a full-size staff) now have the correct beam spacing. |
oktophonie
approved these changes
Dec 9, 2021
fix 64th note wedges for beams at 1 space
fix build
fix vtest crash
Nick-Mazuk
force-pushed
the
beam-level-spacing
branch
from
4468b05
to
88228fa
Compare
RomanPudashkin
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #9683 updated the style preferences for beams for MS4.
One of these style settings is for wide beams, spaced 1 space apart instead of the traditional 0.75 spaces. This PR adds support for this.