Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU4] Fix #8827: converted all templates to the new version of the MSCX format #9985

Merged
merged 5 commits into from
Dec 10, 2021
Merged

[MU4] Fix #8827: converted all templates to the new version of the MSCX format #9985

merged 5 commits into from
Dec 10, 2021

Conversation

RomanPudashkin
Copy link
Contributor

Resolves:
#8827
#8925

@RomanPudashkin RomanPudashkin marked this pull request as draft December 6, 2021 12:14
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Dec 6, 2021 •
edited

This does revert an ealier move (done some years ago) of all templates from mscz to mscx, made to have better and smaller diffs in the git repo.

Edit: much better now IMHO.

@RomanPudashkin RomanPudashkin changed the title [MU4] Fix #8827: converted all mscx templates to the mscz format [WIP] Fix #8827: converted all templates to the new version of the MSCX format Dec 7, 2021
@Jojo-Schmitz
Copy link
Contributor

rebase needed to get around those faile vtest?

This was linked to issues Dec 8, 2021
Bottom part of score is being cropped out in main project window and new score preview #8827
Closed
[MU4 Issue] Larger templates (concert band etc.) don't fit on page #8925
Closed
@DmitryArefiev
Copy link
Contributor

Tested #8827 #8925 on Win10, Mac12, LinuxMint 20.2 - FIXED

Please merge into master

@RomanPudashkin RomanPudashkin changed the title [WIP] Fix #8827: converted all templates to the new version of the MSCX format [MU4] Fix #8827: converted all templates to the new version of the MSCX format Dec 10, 2021
@RomanPudashkin RomanPudashkin marked this pull request as ready for review December 10, 2021 13:12
@vpereverzev vpereverzev merged commit e3145fe into musescore:master Dec 10, 2021
@oktophonie oktophonie mentioned this pull request Dec 13, 2021
Closed
@RomanPudashkin RomanPudashkin deleted the tempaltes_clipping_fix branch February 3, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpereverzev vpereverzev vpereverzev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@RomanPudashkin @Jojo-Schmitz @DmitryArefiev @vpereverzev