Refactor/treesitter highlights #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before attempting to move the whole operation to nvim_set_hl, I chose to
incrementally adopt by making the API of the highlight function the same
(or as close as needed) to nvim_set_hl.
This means I can pass in args just like nvim_set_hl would expect and
internally I can translate that to what vim.cmd("hi! ...") would need.
according to :help `breakindent`: Every wrapped line will continue visually indented (same amount of space as the beginning of that line), thus preserving horizontal blocks of text.
* instead of calling hi like hi.Key = Val, I want to set a table of highlights with key/vals and then iterate through them and apply them one at a time. Previously I was using the `__newindex` metatable method to turn this function call into a modifiable table but now that there is no need for that, the highlight function can be a normal function * organize highlight groups * style changes ' -> " * also add new highlights for dashboard
this is still not a 100% done. There are still a few highlight groups that I need to fix like floating windows and popups (which still show up as transparent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.