Changing exception #425
Merged
Changing exception #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logger.error has now been changed to logger.exception Fixes mushorg#357
Pull Request Test Coverage Report for Build 1125
💛 - Coveralls |
xandfury
requested changes
Jan 4, 2019
bin/conpot
Outdated
| @@ -69,7 +69,7 @@ def logo(): | |||
|
|
|||
|
|
|||
| def on_unhandled_greenlet_exception(dead_greenlet): | |||
| logger.error('Stopping because %s died: %s', dead_greenlet, dead_greenlet.exception) | |||
| logger.exception('Stopping because %s died: %s', dead_greenlet, dead_greenlet.exception) | |||
There was a problem hiding this comment.
Great start! Might as well improve on string formatting 🙂
Suggested change
| logger.exception('Stopping because %s died: %s', dead_greenlet, dead_greenlet.exception) | |
| logger.exception('Stopping because {} died: {}'.format(dead_greenlet, dead_greenlet.exception)) |
the old string was removed and was updated with the new fashion Fixes mushorg#357
|
LGTM. Let us wait to see if others have anything else to say 🙂 |
xandfury
approved these changes
Jan 6, 2019
|
Thanks for the contribution! |
xandfury
added a commit
to xandfury/conpot
that referenced
this pull request
Jul 30, 2019
* Break out port and ip * Roughly handle mushorg#399 (not very PEP-8) * Some PEP-8 adjustments as suggested in mushorg#402 * Adds random generated functions for function pointers in template.xml to support non static register values. * fix tftp test * Fixes crypto quality issues and extra space. * Fix typo. * Fix s7 parameter length calculation * Docker fixes (mushorg#416) * updated Dockerfile * cleanup * image size reduced * multi stage build to reduce image size * moved to alpine * Fixed wrong Docker ports * fix mushorg#418 add missing dependency libffi-dev * Makefile for docker added * Fixed exception loop in the FTP handler * Changing exception (mushorg#425) * updated dockerfile (mushorg#429) - related (mushorg#428) With the recent update to pip 19.01 there was a build slight issue with the docker commands, refer here: pypa/pip#6197 * Revert "docker/dockerfile:Updated dockerfile" (mushorg#432) * Revert "updated dockerfile (mushorg#429) - related (mushorg#428)" This reverts commit fe65c16. * fix docker * Added support for plc-stop signal. (mushorg#447) * Added support for plc-stop signal. * Added support for plc-stop signal and added it's tests. * Added support for plc-stop signal and added it's tests.
srenfo
pushed a commit
to srenfo/conpot
that referenced
this pull request
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logger.error has now been changed to logger.exception
Fixes #357