Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the custom MIB dependency resolution and compiler logic and makes PySNMP do the heavy lifting. PySNMP will compile the MIBs on demand, including dependency resolution.
The previous MIB compilation logic was broken: missing files were correctly compiled, but the compiled files were (by default) put into a directory that wasn't actually searched by PySNMP.
The following lines in
CommandResponder
are the most relevant change in this PR. They replace the custom logic inbuild_pysnmp_mib_wrapper.py
.Other minor changes:
--verbose
) when a symbol from the template configuration was skipped. You were left wondering why nothing would show up insnmpwalk
. This produces a warning now.Other functional changes:
--raw_mib
. Bundle the files inside the template instead, e. g.conpot/templates/foobar/snmp/mibs/my.mib
.--mibpaths
to the more appropriate--mibcache
. This now falls back to PySNMP's default of~/.pysnmp/mibs
, though I have opened an issue that this would be more appropriate under~/.cache
.