Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing user-agent header #24

Closed
glaslos opened this issue Jun 3, 2016 · 1 comment
Closed

Handle missing user-agent header #24

glaslos opened this issue Jun 3, 2016 · 1 comment
Assignees
@afeena
Labels
bug
Milestone
gsoc_sprint_3

Comments

@glaslos
Copy link
Member

glaslos commented Jun 3, 2016

This lookup can cause a KeyError:

tanner/session.py

Line 12 in 110a1d2

self.user_agent = data['headers']['USER-AGENT']

We should probably make lower case the key and test if the user agent is in the header dict.
@glaslos glaslos added the bug label Jun 3, 2016
@glaslos glaslos added this to the gsoc_sprint_2 milestone Jun 3, 2016
@glaslos glaslos modified the milestones: gsoc_sprint_3, gsoc_sprint_2 Jun 3, 2016
@glaslos glaslos mentioned this issue Jun 3, 2016
Closed
@glaslos
Copy link
Member Author

glaslos commented Jun 6, 2016

Closed with 9384e86

@glaslos glaslos closed this as completed Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afeena afeena

Labels
bug
Projects
None yet
Milestone
gsoc_sprint_3
Development

No branches or pull requests
2 participants
@glaslos @afeena