Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music added from new Subsonic provider added as favorites #2359

Closed
1 task done
frigi83 opened this issue May 24, 2024 · 17 comments
Closed
1 task done

Music added from new Subsonic provider added as favorites #2359

frigi83 opened this issue May 24, 2024 · 17 comments
Labels

Comments

@frigi83
Copy link

frigi83 commented May 24, 2024

What version of Music Assistant has the issue?

2.0.4

What version of the Home Assistant Integration have you got installed?

2024.5.1

Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

  • Yes

The problem

Wen I add a new subsonic music provider to my MA, all the music (traces, albums, artists, playlist,...) is added as favorites.

I have opened an issue because is not optimal (for large music gallery).

The best solution is to have a full synchronization between MA and Subsonic (see the discussion #2358).

How to reproduce

  1. Create a subsonic server (Navidrome or Gonic)
  2. Create mark some albums and songs as favorites
  3. In MA add the Subsonic music provider
  4. In MA all the songs, albums and artists are marked as favorites

Music Providers

Subsonic

Player Providers

Sonos

Full log output

No response

Additional information

No response

What version of Home Assistant Core are your running

2024.5.4

What type of installation are you running?

Home Assistant OS

On what type of hardware are you running?

Raspberry Pi

@frigi83 frigi83 added the triage label May 24, 2024
@OzGav
Copy link
Contributor

OzGav commented May 24, 2024

Thoughts @khers?

@khers
Copy link

khers commented May 25, 2024

What size library are we talking? I have ~1200 albums, ~1100 artists, and ~12000 tracks and I don't see performance problems.

This doesn't feel like a bug to me, more like a feature request.

@frigi83
Copy link
Author

frigi83 commented May 25, 2024

What size library are we talking? I have ~1200 albums, ~1100 artists, and ~12000 tracks and I don't see performance problems.

I apologize, it is probably a misunderstanding due to my bad English.

It is not a performance problem, but a problem with the addition of a Subsonic music provider. The problem is that all music added is automatically added as a favorite in MA. Removing the favorite from all music takes quite a long time (in case of large music collections).

This doesn't feel like a bug to me, more like a feature request.

I agree that synchronization in both directions is a new requirement and I tried to describe it in the discussion (#2358).

@khers
Copy link

khers commented May 25, 2024

I am not sure I understand. Where are things marked as favorite in MA? Nothing in my Gonic server is marked as favorite. Are you saying that you want something that is marked as favorite in one to also be marked that way in the other?

As for playlists, I added support for playlists that are in the open subsonic to show up in MA but have not implemented pushing playlist changes back mostly because I don't ever use them. I can look into pushing playlist changes back to the server but that is going be a bit before I can put time into it.

@frigi83
Copy link
Author

frigi83 commented May 25, 2024

If you take a new instance of MA and try to add a open subsonic server (like Gonic or Navidrome) as new music provider. All the music (artists, albums, playlists and tracks) are marked in MA as favorites. Regardless of whether on the server some items are marked as favorites.

As for playlists, I added support for playlists that are in the open subsonic to show up in MA but have not implemented pushing playlist changes back mostly because I don't ever use them. I can look into pushing playlist changes back to the server but that is going be a bit before I can put time into it.

This would be fantastic

@OzGav
Copy link
Contributor

OzGav commented May 26, 2024

Just to confirm when you say marked as favourite you are seeing the filled heart icon next to all of the items?

image

@frigi83
Copy link
Author

frigi83 commented May 26, 2024

Just to confirm when you say marked as favourite you are seeing the filled heart icon next to all of the items?

Yes

@khers
Copy link

khers commented May 26, 2024

I am seeing this same behavior but it is not consistent. The subsonic provider does not set the favorite field for any of the items so that should default to False.

@frigi83
Copy link
Author

frigi83 commented May 26, 2024

I am seeing this same behavior but it is not consistent. The subsonic provider does not set the favorite field for any of the items so that should default to False.

@khers wich Subsonic server do you have? I have tested with Gonic and Navidrome

@khers
Copy link

khers commented May 26, 2024

I use Gonic

@daniele-athome
Copy link

daniele-athome commented May 28, 2024

I just installed Music Assistant and added my Navidrome server as source and got the same problem: all tracks were set as favorite in MA. This also has the side effect that when I open the MA built-in playlist "All favorited tracks" (from MA built-in web UI) the browser hangs.

EDIT: I don't know if it's a limitation in MA playlists, but I can tell that of my 12k tracks only 2500 (precise count) are displayed in the "All favorited tracks" playlist.

@khers
Copy link

khers commented Jun 4, 2024

@marcelveldt mentioned on discord that this is a known issue (outside the subsonic provider) and that a fix is in the works.

@OzGav
Copy link
Contributor

OzGav commented Jun 12, 2024

Closing at OP request

@OzGav OzGav closed this as completed Jun 12, 2024
@leokeba
Copy link

leokeba commented Jul 6, 2024

Sorry to revive a closed issue, but has this been fixed already ? I'm having the same issue with my Navidrome instance, and the favorites features pretty much mandatory for me to be able to navigate anything, my music collection is too big to just scroll into.

@khers
Copy link

khers commented Jul 6, 2024

The fix is in the betas for 2.1 for sure, I do now know if it was backported to the stable branch.

@leokeba
Copy link

leokeba commented Jul 6, 2024

Thanks, I'm using the Home Assistant Add-On which advertises itself as "2.0.7", is there a not-too-involved way for me to get the latest beta ?

Edit : NVM, I found out, the issue is fixed in the beta channel :)

@marcelveldt
Copy link
Member

The 2.1 version will be released somewhere between now and 2 weeks so you could also wait for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants