-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Music added from new Subsonic provider added as favorites #2359
Comments
Thoughts @khers? |
What size library are we talking? I have ~1200 albums, ~1100 artists, and ~12000 tracks and I don't see performance problems. This doesn't feel like a bug to me, more like a feature request. |
I apologize, it is probably a misunderstanding due to my bad English. It is not a performance problem, but a problem with the addition of a Subsonic music provider. The problem is that all music added is automatically added as a favorite in MA. Removing the favorite from all music takes quite a long time (in case of large music collections).
I agree that synchronization in both directions is a new requirement and I tried to describe it in the discussion (#2358). |
I am not sure I understand. Where are things marked as favorite in MA? Nothing in my Gonic server is marked as favorite. Are you saying that you want something that is marked as favorite in one to also be marked that way in the other? As for playlists, I added support for playlists that are in the open subsonic to show up in MA but have not implemented pushing playlist changes back mostly because I don't ever use them. I can look into pushing playlist changes back to the server but that is going be a bit before I can put time into it. |
If you take a new instance of MA and try to add a open subsonic server (like Gonic or Navidrome) as new music provider. All the music (artists, albums, playlists and tracks) are marked in MA as favorites. Regardless of whether on the server some items are marked as favorites.
This would be fantastic |
I am seeing this same behavior but it is not consistent. The subsonic provider does not set the favorite field for any of the items so that should default to False. |
@khers wich Subsonic server do you have? I have tested with Gonic and Navidrome |
I use Gonic |
I just installed Music Assistant and added my Navidrome server as source and got the same problem: all tracks were set as favorite in MA. This also has the side effect that when I open the MA built-in playlist "All favorited tracks" (from MA built-in web UI) the browser hangs. EDIT: I don't know if it's a limitation in MA playlists, but I can tell that of my 12k tracks only 2500 (precise count) are displayed in the "All favorited tracks" playlist. |
@marcelveldt mentioned on discord that this is a known issue (outside the subsonic provider) and that a fix is in the works. |
Closing at OP request |
Sorry to revive a closed issue, but has this been fixed already ? I'm having the same issue with my Navidrome instance, and the favorites features pretty much mandatory for me to be able to navigate anything, my music collection is too big to just scroll into. |
The fix is in the betas for 2.1 for sure, I do now know if it was backported to the stable branch. |
Thanks, I'm using the Home Assistant Add-On which advertises itself as "2.0.7", is there a not-too-involved way for me to get the latest beta ? Edit : NVM, I found out, the issue is fixed in the beta channel :) |
The 2.1 version will be released somewhere between now and 2 weeks so you could also wait for that |
What version of Music Assistant has the issue?
2.0.4
What version of the Home Assistant Integration have you got installed?
2024.5.1
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?
The problem
Wen I add a new subsonic music provider to my MA, all the music (traces, albums, artists, playlist,...) is added as favorites.
I have opened an issue because is not optimal (for large music gallery).
The best solution is to have a full synchronization between MA and Subsonic (see the discussion #2358).
How to reproduce
Music Providers
Subsonic
Player Providers
Sonos
Full log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2024.5.4
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Raspberry Pi
The text was updated successfully, but these errors were encountered: