Fixed stream_ip resolution for kubernetes users #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this and ignore my previous comment. Did not yet had my coffee in the morning ;-) |
marcelveldt
requested changes
Jun 25, 2022
Co-authored-by: Marcel van der Veldt <m.vanderveldt@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the recommendation given in #500 where the stream_ip is resolved from the internal url. In the case where the stream_ip is not resolvable from the internal url we fall back to
hass.config.api.local_ip. I tested this out and it works with both hostname based internal_urls and ip based internal_urls.IP Based
Hostname Based