Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken example #197

Closed
wants to merge 2 commits into from
Closed

Fix broken example #197

wants to merge 2 commits into from

Conversation

lmagyar
Copy link
Contributor

@lmagyar lmagyar commented Jun 17, 2024 •
edited
Loading

Issues:

  • without start_listening(), subscribe_events() will never receive it's response from the server
  • start_listening() have to be the first call, but it blocks, so we have to put it in a task, and we have to eg. log it's exception
  • we need eg. a sleep to wait for the messages, but we could also await for the created task also

fixes: #186

@lmagyar
fix example
e3369db 
- without start_listening(), subscribe_events() will never receive it's response from the server
- start_listening() have to the first, but it blocks, we have to put it in a task, and we have to log it's exception
- we need eg. a sleep to wait for the messages, but we could await for the task also
marcelveldt
marcelveldt reviewed Jun 17, 2024
View reviewed changes
example.py Outdated Show resolved Hide resolved
marcelveldt
marcelveldt reviewed Jun 17, 2024
View reviewed changes
example.py Outdated Show resolved Hide resolved
@marcelveldt marcelveldt added the enhancement New feature or request label Jun 18, 2024
@lmagyar
Copy link
Contributor Author

lmagyar commented Jul 7, 2024

Closing, as this got fixed with v1.2.0.

@lmagyar lmagyar closed this Jul 7, 2024
@lmagyar lmagyar deleted the fix-example branch July 7, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelveldt marcelveldt marcelveldt approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seems to be completely broken, example code doesn't work
2 participants
@lmagyar @marcelveldt