Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plex Connect Locally #1313

Merged
merged 19 commits into from
Jun 9, 2024
Merged

Conversation

lordbah
Copy link
Contributor

@lordbah lordbah commented May 17, 2024

Add Plex Connect Locally
Set Favorite for tracks rated 5 stars in Plex

@lordbah
Copy link
Contributor Author

lordbah commented May 17, 2024

When adding the Plex music provider you can avoid using Myplex.TV. Fill in the IP address and port and click Connect Locally. There is no visible reaction. Hit Save. The provider syncs in the background, connecting directly to the Plex server without requiring a token from Myplex.TV. Also, tracks rated 5 stars in Plex will have the Favorite flag set.

Co-authored-by: Marcel van der Veldt <m.vanderveldt@outlook.com>
@marcelveldt
Copy link
Member

I made a few changes to the PR to make it more explicit that you can choose between Local auth and MyPlex auth.
I had no way to test the local auth option, can give that a double check before we merge here ?

@marcelveldt
Copy link
Member

Can you deliver a small piece of text for the documentation about using the local auth ?

marcelveldt
marcelveldt previously approved these changes Jun 1, 2024
@lordbah
Copy link
Contributor Author

lordbah commented Jun 1, 2024

Can you deliver a small piece of text for the documentation about using the local auth ?

Is the comment in the PR sufficient?

@marcelveldt
Copy link
Member

Can you deliver a small piece of text for the documentation about using the local auth ?

Is the comment in the PR sufficient?

Uhh well, I tried it myself and it didnt work out of the box so I assume there is also a part needed in Plex itself ?

@lordbah
Copy link
Contributor Author

lordbah commented Jun 1, 2024

Can you deliver a small piece of text for the documentation about using the local auth ?

Is the comment in the PR sufficient?

Uhh well, I tried it myself and it didnt work out of the box so I assume there is also a part needed in Plex itself ?

In Plex under Settings / Remote Access, "List of IP addresses and networks that are allowed without auth" is a comma-separated list. Mine is set to "192.168.218.0/255.255.254.0,192.168.220.165". I guess I assumed that anyone who would want to connect locally would already have that.

@marcelveldt
Copy link
Member

Can you deliver a small piece of text for the documentation about using the local auth ?

Is the comment in the PR sufficient?

Uhh well, I tried it myself and it didnt work out of the box so I assume there is also a part needed in Plex itself ?

In Plex under Settings / Remote Access, "List of IP addresses and networks that are allowed without auth" is a comma-separated list. Mine is set to "192.168.218.0/255.255.254.0,192.168.220.165". I guess I assumed that anyone who would want to connect locally would already have that.

Let's add this info to the docs then as it was new info for me. Thanks!

Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lordbah !

@marcelveldt marcelveldt merged commit 4234c43 into music-assistant:main Jun 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants