Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube Music: Add library add/remove and playlist track add/remove functionality #425

Merged
merged 11 commits into from
Jul 16, 2022

Conversation

MarvinSchenkel
Copy link
Contributor

This PR adds the following to Youtube Music:

  • Adding/Removing Artists to library
  • Adding/Removing Albums to library
  • Adding/Removing Playlists to library
  • Adding/Removing tracks to a playlist
  • Fix library sync of artists

marcelveldt
marcelveldt previously approved these changes Jul 16, 2022
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some tiny return type thingies this looks great!

music_assistant/music_providers/ytmusic/ytmusic.py Outdated Show resolved Hide resolved
raise NotImplementedError
return result

async def library_remove(self, prov_item_id, media_type: MediaType):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
async def library_remove(self, prov_item_id, media_type: MediaType):
async def library_remove(self, prov_item_id, media_type: MediaType) -> None:

Co-authored-by: Marcel van der Veldt <m.vanderveldt@outlook.com>
@MarvinSchenkel MarvinSchenkel merged commit 0a78094 into master Jul 16, 2022
@MarvinSchenkel MarvinSchenkel deleted the feature/library_add_functions branch July 16, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants