Add support for local cover art #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return | ||
| self.next_in_queue() | ||
| return | ||
| except AttributeError: |
There was a problem hiding this comment.
Is this for handling the missing filepath attribute on images that don't have it? If so, that seems overly broad and should be replaced with isinstance or hasattr calls.
There was a problem hiding this comment.
I went for hasattr() in a3351d5
Suggested by Mineo
- try/except is more pythonic, but less readable, even if narrowed - hasattr() is pythonic enough, and more readable - isinstance() isn't pythonic enough (and forces to import the class)
zas
added a commit
that referenced
this pull request
Jul 12, 2015
Add support for local cover art http://tickets.musicbrainz.org/browse/PICARD-137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds a cover art provider, which, when enabled, looks for files like cover.jpg, etc.. in local directory (where sound files are) and use image files found as cover art.
Inspired by http://forums.musicbrainz.org/viewtopic.php?id=2859
Solves:
http://tickets.musicbrainz.org/browse/PICARD-137
Related:
http://tickets.musicbrainz.org/browse/PICARD-257
http://tickets.musicbrainz.org/browse/PICARD-187